Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellcheck v0.4.6 warnings #7040

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Fix shellcheck v0.4.6 warnings #7040

merged 2 commits into from
Jan 17, 2018

Conversation

behlendorf
Copy link
Contributor

Description

Resolve new warnings reported after upgrading to shellcheck version 0.4.6. This patch contains no functional changes.

  • egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
  • Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. [SC2181]

Motivation and Context

Keep the build clean with newer versions of shellcheck.

How Has This Been Tested?

make checkstyle

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@behlendorf behlendorf mentioned this pull request Jan 16, 2018
Merged
13 tasks
@dinatale2 dinatale2 requested review from dun and removed request for dun January 16, 2018 23:41
@behlendorf
Fix shellcheck v0.4.6 warnings
793501c 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@codecov
Copy link

codecov bot commented Jan 17, 2018 •
edited
Loading

Codecov Report

Merging #7040 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7040      +/-   ##
==========================================
+ Coverage   75.41%   75.45%   +0.04%     
==========================================
  Files         296      296              
  Lines       95528    95528              
==========================================
+ Hits        72043    72084      +41     
+ Misses      23485    23444      -41
Flag Coverage Δ
#kernel 74.68% <ø> (-0.05%) ⬇️
#user 67.78% <ø> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d658b2c...264fa80. Read the comment docs.

@behlendorf behlendorf mentioned this pull request Jan 17, 2018
Closed
7 tasks
@behlendorf behlendorf requested a review from dinatale2 January 17, 2018 04:21
dinatale2
dinatale2 approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@dinatale2 dinatale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@behlendorf
Review feedback
264fa80 
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf mentioned this pull request Jan 17, 2018
Merged
13 tasks
@behlendorf behlendorf merged commit 3da3488 into openzfs:master Jan 17, 2018
prometheanfire pushed a commit to prometheanfire/zfs that referenced this pull request Jan 17, 2018
@behlendorf @prometheanfire
Fix shellcheck v0.4.6 warnings
e941cbb 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#7040
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 18, 2018
@behlendorf @tonyhutter
Fix shellcheck v0.4.6 warnings
608e0d1 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#7040
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 18, 2018
@behlendorf @tonyhutter
Fix shellcheck v0.4.6 warnings
f56e261 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#7040
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 19, 2018
@behlendorf @tonyhutter
Fix shellcheck v0.4.6 warnings
daa4a91 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#7040
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 22, 2018
@behlendorf @tonyhutter
Fix shellcheck v0.4.6 warnings
99e90e8 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#7040
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 22, 2018
@behlendorf @tonyhutter
Fix shellcheck v0.4.6 warnings
718136d 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#7040

Requires-spl: refs/pull/679/head
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 23, 2018
@behlendorf @tonyhutter
Fix shellcheck v0.4.6 warnings
02aea3a 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#7040

Requires-spl: refs/pull/679/head
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 24, 2018
@behlendorf @tonyhutter
Fix shellcheck v0.4.6 warnings
046a72e 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#7040
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Jan 29, 2018
@behlendorf @Nasf-Fan
Fix shellcheck v0.4.6 warnings
7331f14 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#7040
tonyhutter pushed a commit that referenced this pull request Feb 6, 2018
@behlendorf @tonyhutter
Fix shellcheck v0.4.6 warnings
9d1a39c 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #7040
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Feb 13, 2018
@behlendorf @Nasf-Fan
Fix shellcheck v0.4.6 warnings
7e912f1 
Resolve new warnings reported after upgrading to shellcheck
version 0.4.6.  This patch contains no functional changes.

* egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
* Check exit code directly with e.g. 'if mycmd;', not indirectly
  with $?.  [SC2181]  Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#7040
@behlendorf behlendorf deleted the shellcheck branch April 19, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinatale2 dinatale2 dinatale2 approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @gmelikov @dinatale2